Two errors when running ssh in a bash script

Question

I try to run this script against a remote machine, to carry out login check, but have some problems executing it with no errors. I have the following error when I run the script: The Error:

bash: -c: option requires an argument
bash: line 2: [: missing `]'

The Shell Script:

#!/bin/bash
ssh root@192.168.88.20 bash -c '
radtest user password 127.0.0.1 100 testing | grep 'Access-Accept' &> /dev/null
if [ $? == 0]; then
        echo "match"
fi
'

Any ideas what could cases the error? Note: ssh doesn't need a password here.

You can compress that to: if radtest user password 127.0.0.1 100 testing | grep -q "Access-Accept"; then ... — muru, Feb 17 '15 at 23:17

taliezin · Accepted Answer · 2015-02-17T23:47:54.977

1

I think this:

if [ $? == 0];

should be:

if [ $? == 0 ];

But as muru suggested it can be:

#!/bin/bash
ssh root@192.168.88.20 bash -c '"
if radtest user password 127.0.0.1 100 testing | grep -q "Access-Accept"; then
echo "Match"
fi
"'

edited Feb 17 '15 at 23:47

answered Feb 17 '15 at 23:05

taliezin

9,275

Invert the quote order, or $? will be expanded by the current shell. – muru Feb 17 '15 at 23:16
sorry I didn't see that error in question I am going to delete this. Or I'll try to edit it. – taliezin Feb 17 '15 at 23:32
@taliezin Ok, so the core is working now but still the fist minor error is there: bash: -c: option requires an argument. However, the main functions are working now. – Gazel Feb 17 '15 at 23:47
I edited it. Sorry did not see he first error. – taliezin Feb 17 '15 at 23:49
Much appreciated. – Gazel Feb 19 '15 at 00:05

Two errors when running ssh in a bash script

1 Answers1